-
Notifications
You must be signed in to change notification settings - Fork 2
Generate only route clients and related types #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can you update https://github.com/seamapi/python-next/blob/main/.gitattributes so the diff shows the "no longer generated" files? |
| from seam.types import AbstractSeam as Seam | ||
| from seam.routes.types import AbstractAccessCodes, AccessCode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| from seam.types import AbstractSeam as Seam | |
| from seam.routes.types import AbstractAccessCodes, AccessCode | |
| from ..types import AbstractSeam as Seam | |
| from .types import AbstractAccessCodes, AccessCode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Relevant issue #54
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why a relative import ..types is better than an absolute seam.types? As for me, absolute imports from top level looks clearer.
| SeamActionAttemptTimeoutError, | ||
| ) | ||
|
|
||
| class SeamActionAttemptError(Exception): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move the errors and special methods out of codegen? We can address this separately from this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any other places in the codegen that are "special" like this, i.e., include code or special logic specific to a generated file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think its only action attempts with their custom errors and polling methods.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Relevant issue #55
|
Ok to merge this and address the comments later, I know there are other PRs waiting on this. I just wanted to note anything I noticed while reviewing. I don't see any blockers and isolating the codegen to routes means contributing from this repo is unlocked! |
Co-authored-by: Evan Sosenko <evan@getseam.com>
Co-authored-by: Evan Sosenko <evan@getseam.com>
Co-authored-by: Evan Sosenko <evan@getseam.com>
Uh oh!
There was an error while loading. Please reload this page.