Skip to content

fix: Handle non-json error responses #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrii-balitskyi merged 7 commits into from
Feb 13, 2025
Merged

fix: Handle non-json error responses #263

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a2ed4fc
Handle non-json error responses
andrii-balitskyi Feb 12, 2025
756479b
Catch specific errors
andrii-balitskyi Feb 12, 2025
d2c5bf1
Fix lint too many return statements
andrii-balitskyi Feb 12, 2025
0204dce
Test non-standard response
andrii-balitskyi Feb 12, 2025
0e5aa28
Merge branch 'main' into andrii/cx-121-handle-non-json-error-response
andrii-balitskyi Feb 12, 2025
1ab722e
Move is_api_error_response out of SeamHttpClient class
andrii-balitskyi Feb 13, 2025
a0b8622
Merge branch 'main' into andrii/cx-121-handle-non-json-error-response
andrii-balitskyi Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Test non-standard response
  • Loading branch information
@andrii-balitskyi
andrii-balitskyi committed Feb 12, 2025
commit 0204dce5f67f1b7218bb9bd812d007d414f9dfcd
16 changes: 16 additions & 0 deletions test/http_error_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import pytest
import niquests
from seam import Seam
from seam.exceptions import (
SeamHttpApiError,
Expand Down Expand Up @@ -44,3 +45,18 @@ def test_seam_http_throws_invalid_input_error(server):
assert err.status_code == 400
assert err.code == "invalid_input"
assert err.request_id.startswith("request")


def test_seam_http_throws_http_error_on_non_standard_response(server):
endpoint, seed = server
seam = Seam.from_api_key(seed["seam_apikey1_token"], endpoint=endpoint)

seam.client.post(
"/_fake/simulate_workspace_outage",
json={"workspace_id": seed["seed_workspace_1"], "routes": ["/devices/list"]},
)

with pytest.raises(niquests.HTTPError) as exc_info:
seam.devices.list()

assert exc_info.value.response.status_code == 503
Loading