This repository was archived by the owner on Jun 28, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3
Add Sentry integration #57
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d4ed7a8 to
96153fe
Compare
seveibar
reviewed
Oct 12, 2022
seveibar
reviewed
Oct 12, 2022
seveibar
reviewed
Oct 12, 2022
seveibar
reviewed
Oct 12, 2022
Contributor
seveibar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think if a user uses sentry_sdk we'll interact with their singleton, wdyt about creating a client
seveibar
approved these changes
Oct 13, 2022
seveibar
reviewed
Oct 13, 2022
| default_integrations=False, | ||
| ) | ||
| sentry_sdk.set_context("sdk_info", { | ||
| )) |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
github-actions bot
pushed a commit
that referenced
this pull request
Oct 13, 2022
## [2.2.0](seamapi/python@v2.1.0...v2.2.0) (2022-10-13) ### Features * Merge pull request [#57](seamapi/python#57) from seamapi/feat-sentry ([20605d5](seamapi/python@20605d5))
Contributor
|
🎉 This issue has been resolved in version 2.2.0 🎉 The release is available on PyPI and GitHub. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation feels a bit hacky but not sure if there's a better way to do it.