Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(web): disconnect smart delegate + UI/UX improvements + address mocha's feedback re: mint/decimals & toast #75

Merged
merged 1 commit into from
Oct 18, 2023
Merged

feat(web): disconnect smart delegate + UI/UX improvements + address mocha's feedback re: mint/decimals & toast #75

merged 1 commit into from
Oct 18, 2023

Conversation

sol-matcha
Copy link
Member

No description provided.

@sol-matcha sol-matcha requested a review from sol-mocha October 18, 2023 03:46
@sol-matcha sol-matcha self-assigned this Oct 18, 2023
@vercel
Copy link

vercel bot commented Oct 18, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pre-authorized-debit-v1 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2023 3:53am

sol-mocha
sol-mocha reviewed Oct 18, 2023
View reviewed changes
Copy link
Member

@sol-mocha sol-mocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general lgtm, but didnt look line-by-line.

But did see this

        // pad(date.getMinutes()) +
        // ':' +
        // pad(date.getSeconds()) +
        // dif +
        // pad(Math.floor(Math.abs(tzo) / 60)) +
        // ':' +
        // pad(Math.abs(tzo) % 60)

Do we still need this?

web/src/components/CreatePreAuthorizationModal.tsx
@@ -149,7 +150,7 @@ const CreatePreAuthorizationModal: React.FC<CreatePreAuthorizationModalProps> =

try {
let authorizedAmount = new Decimal(authorizedAmountStr);
const decimals = token!.decimals;
const decimals = token?.decimals ?? mint?.decimals ?? 0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For decimals, shouldn't mint get priority in this since its native to the mint state?

web/src/contexts/TokenAccounts.tsx
Comment on lines +77 to +78
let tokenMintAccountInfos: ({ pubkey: PublicKey } & AccountInfo<Buffer>)[] = [];
let token2022MintAccountInfos: ({ pubkey: PublicKey } & AccountInfo<Buffer>)[] = [];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see these getting re-assigned, they can prob be a const.

@sol-matcha sol-matcha merged commit 54d5595 into main Oct 18, 2023
8 checks passed
@sol-matcha sol-matcha deleted the matcha/web-ui-changes branch October 18, 2023 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sol-mocha sol-mocha sol-mocha left review comments

Assignees

@sol-matcha sol-matcha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sol-matcha @sol-mocha