Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: remove deprecated astyle option #200

Merged
merged 1 commit into from
Apr 28, 2024
Merged

Conversation

Ivan-Velickovic
Copy link
Contributor

Release 3.0 of astyle replaced this option with
'max-continuation-indent'. The replaced option is already in the astylerc so we just need to remove the option here.

Further information can be found in the release notes: https://astyle.sourceforge.net/news.html

Release 3.0 of astyle replaced this option with
'max-continuation-indent'. The replaced option is already in
the astylerc so we just need to remove the option here.

Further information can be found in the release notes:
https://astyle.sourceforge.net/news.html

Signed-off-by: Ivan Velickovic <i.velickovic@unsw.edu.au>
Copy link
Member

@lsf37 lsf37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with removing it, but it means we need to update the recommended version in the style guide (which is ancient). It looks like the output is stable, so I'll put up a PR for that.

@lsf37
Copy link
Member

lsf37 commented Apr 28, 2024

Just for posterity: the issue is not that the option has been replaced in 3.0, it is that it is now no longer recognised in more recent version. We had both for a while, but now only astyle versions >= 3.0 will work.

@lsf37 lsf37 merged commit 6789652 into master Apr 28, 2024
20 checks passed
@lsf37 lsf37 deleted the remove_deprecated_option branch April 28, 2024 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants