elfloader: initialise stack allocated struct #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivan-Velickovic
force-pushed
the
initialise_struct
branch
from
031858b
to
fefc061
Compare
|
Maybe the compiler warning configuration is different in the projects? |
axel-h
reviewed
Apr 9, 2024
| @@ -61,7 +61,7 @@ static __attribute__((noinline)) int send_smc(uint8_t func, struct mce_regs *reg | |||
|
|
|||
| static void tegra_mce_write_uncore_mca(mca_cmd_t cmd, uint64_t data, uint32_t *err) | |||
| { | |||
| struct mce_regs regs; | |||
| struct mce_regs regs = {0}; | |||
There was a problem hiding this comment.
If gcc complain here, it should also complain about line 74 below in enable_serr(), where mca_cmd_t cmd has uninitialized fields, as it is also a stack variable that will start with content and we don't set all members. We should initialize this will all zeros also.
There was a problem hiding this comment.
gcc might be smart enough to figure out that only the initialised fields are used from the one in line 74, esp if it inlines it. In fact, it appears enable_serr sets two fields of that struct/union that are never used. regs here on the other hand is passed to an asm block, so gcc is unlikely to know more.
lsf37
approved these changes
Aug 9, 2024
Only results in a compilation error on newer GCC versions. Signed-off-by: Ivan Velickovic <i.velickovic@unsw.edu.au>
Ivan-Velickovic
force-pushed
the
initialise_struct
branch
from
fefc061
to
c4220b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only results in a compilation error on newer GCC versions.
What confuses me though is this only happens for me in sel4bench, but not sel4test. I believe I'm using the same compiler in both projects, but se4lbench results in a unitialised warning that is treated as a compile error. sel4test does not even print the warning?