-
Notifications
You must be signed in to change notification settings - Fork 16
platforms: add Pine64 Star64 #283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
9e74e67 to
17951c4
Compare
seL4-platforms/platforms.yml
Outdated
| smp: [64] | ||
| platform: star64 | ||
| req: [star64] | ||
| march: rv64imac |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what march does exactly here, march: rv64gcb would be more accurate for the Star64. The only use of march I can see is here
ci-actions/seL4-platforms/platforms.py
Lines 183 to 192 in 607634d
| def getISA(self, mode: int) -> str: | |
| """Return the ISA for this platform""" | |
| if self.arch == "x86": | |
| return {32: "IA32", 64: "x86_64"}[mode] | |
| if self.arch == "riscv": | |
| return {32: "RC32IMAC", 64: "RV64IMAC"}[mode] | |
| return self.march.capitalize() |
march anyways.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might be wrong, but I think the only remaining use of march is for grouping in CI matrices. We could try to eliminate it and see what happens..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a survey of this for PR #385 and it's a bit of work. So for now, to merge new platforms we should use the old rv64imac even if that is not accurate any more.
lsf37
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Happy for you to merge once the other PRs are done.
(Ok to ignore the devscript link failure for this PR)
Signed-off-by: Ivan-Velickovic <i.velickovic@unsw.edu.au>
| smp: [64] | ||
| platform: star64 | ||
| req: [star64] | ||
| march: rv64imafdc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now we still need the old version
| march: rv64imafdc | |
| march: rv64imac |
For once all the Star64 PRs are merged.