-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug/265 - enable working hour function and issue/272 - new UI for setting page to work with working hour function #279
Conversation
brianzhang310
commented
Apr 22, 2020
•
edited
Loading
edited
- The pull request is complete according to the following criteria:
- Acceptance criteria have been met
- The documentation is kept up-to-date
- Comprehensive tests (if applicable) have been generated and all pass.
- The pull request describes the changes that have been made, and enough information is present in the description for any developer to understand what has changed
- Commits have been squashed (or will be on merge).
- The branch name is descriptive and follows the pull request title format : {issue/bug...}/(Issue Number) - Name of issue. E.g bug/30-Fix-Project
- The pull request title is of the following format : {issue/bug...}/(Issue Number) - Name of issue. E.g bug/30-Fix-Project
- The description uses github syntax to link to the issue. E,g Resolves se701g2/Doto#{Number}
- At least two reviewers assigned. One of which must be the assigner of the issue.
- If there are merge conflicts, run git rebase as opposed to git merge with master.
A little summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally no errors on my side, LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes from the comments. Tested out locally and the tasks get reallocated when the working hours are changed.
@all-contributors please add @brianzhang310 for code, review, doc |
I've put up a pull request to add @brianzhang310! 🎉 |