Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/#108-Use promise to use .catch statement #109

Closed
wants to merge 3 commits into from

Conversation

ryumy97
Copy link
Contributor

@ryumy97 ryumy97 commented Mar 15, 2020

.save() and .find() is async function. We want to use Promise to handle these operations

resolves #108

  • The pull request is complete according to the following criteria:
    • Acceptance criteria have been met
    • The documentation is kept up-to-date
    • Comprehensive tests (if applicable) have been generated and all pass.
    • The pull request describes the changes that have been made, and enough information is present in the description for any developer to understand what has changed
    • Commits have been squashed (or will be on merge).
    • The branch name is descriptive and follows the pull request title format : {issue/bug...}/(Issue Number) - Name of issue. E.g bug/30-Fix-Project
    • The pull request title is of the following format : {issue/bug...}/(Issue Number) - Name of issue. E.g bug/30-Fix-Project
    • The description uses github syntax to link to the issue. E,g Resolves se701g2/Doto#{Number}
    • At least two reviewers assigned. One of which must be the assigner of the issue.
    • If there are merge conflicts, run git rebase as opposed to git merge with master.

@ryumy97 ryumy97 mentioned this pull request Mar 15, 2020
@tnzhu
Copy link
Contributor

tnzhu commented Mar 16, 2020

@Cvos0162 Heya, backend is working on this, so I don't think this will go through.

@ryumy97
Copy link
Contributor Author

ryumy97 commented Mar 16, 2020

@Cvos0162 Heya, backend is working on this, so I don't think this will go through.

Oh, that's cool. I was just passing by and thought this was good coding practice.
Anyway, the issue is still valid since there are no changes in the code. Please make sure to reference the issue #108 on the new PR, when someone actually handles them.
(Although I think, there is no reason to pick this PR up, but that's ok)

@res550
Copy link
Contributor

res550 commented Mar 19, 2020

Hey @Cvos0162 and @tnzhu whats the status for the other can we close this one

@tnzhu
Copy link
Contributor

tnzhu commented Mar 19, 2020

Hey @Cvos0162 and @tnzhu whats the status for the other can we close this one

Yeah, I think the plan is to refactor once all changes are made.

@res550
Copy link
Contributor

res550 commented Mar 19, 2020

Okay cool that sounds good

@tnzhu tnzhu closed this Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Promises when communicating with db
3 participants