names of variables changed#11
Open
florencemayo wants to merge 1 commit into
Open
Conversation
chrberger
requested changes
Oct 13, 2016
| stopCar(); | ||
|
|
||
| delete (driver_ptr); | ||
| delete (driverGeneric); |
Contributor
There was a problem hiding this comment.
Instead of actively deleting a pointer, you should use unique_ptr or shared_ptr to let C++ do that for you.
| cout << "Creating Lane Following driver" << endl; | ||
| driver_ptr = new LaneFollowingDriver(argc, argv); | ||
| if (!driver_ptr) { | ||
| driverGeneric = new LaneFollowingDriver(argc, argv); |
Contributor
There was a problem hiding this comment.
Here, we shouldn't use pointers but wrap them into unique_ptr or shared_ptr.
| cout << "Creating Parking driver" << endl; | ||
| driver_ptr = new ParkingDriver(argc, argv); | ||
| if (!driver_ptr) { | ||
| driverGeneric = new ParkingDriver(argc, argv); |
Contributor
There was a problem hiding this comment.
Here, we shouldn't use pointers but wrap them into unique_ptr or shared_ptr.
| if (!driver_ptr) { | ||
| else if (!laneFollowingButton && !parkingButton && overtakingButton) { | ||
| if (driver_state != Overtaking) { | ||
| //driverGeneric = new OvertakingDriver(argc, argv); |
Contributor
There was a problem hiding this comment.
Here, we shouldn't use pointers but wrap them into unique_ptr or shared_ptr.
| laneDriver = new LaneFollowingDriver(argc, argv); | ||
| // Init laneDriver module | ||
| laneDriver->runModule(); | ||
| laneFollowingDriver = new LaneFollowingDriver(argc, argv); |
Contributor
There was a problem hiding this comment.
Here, we shouldn't use pointers but wrap them into unique_ptr or shared_ptr.
|
|
||
| ParkingDriver::~ParkingDriver() { | ||
| free(laneDriver); | ||
| free(laneFollowingDriver); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.