Upstream merger #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds missing typespecs * Adds `:table` protocol implementation
Co-authored-by: Greg Rychlewski <grychle@LLL7WPM64V5M.ngco.com>
Co-authored-by: Greg Rychlewski <grychle@LLL7WPM64V5M.ngco.com>
Co-authored-by: Greg Rychlewski <grychle@LLL7WPM64V5M.ngco.com>
We don't want the sqlite3 connection getting garbage collected before the statement is finalized.
Error reasons are sent as atoms from the NIF side
* add precompilation support for musl targets * using cc_precompiler v0.1.7
alanj853
requested review from
metelik,
adrigonzo,
bjmurphySE,
PeterJeaiem and
david-naughton
metelik
approved these changes
Apr 28, 2023
david-naughton
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main reason for this upgrade is to get the seg fault fix in the NIF: elixir-sqlite#218.
** update **
There is no negative impact, if anything it uses slightly less memory.