Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sampling API to docs #742

Merged
merged 1 commit into from
Mar 24, 2022
Merged

Add sampling API to docs #742

merged 1 commit into from
Mar 24, 2022

Conversation

katxiao
Copy link
Contributor

@katxiao katxiao commented Mar 23, 2022

Resolves #740

Also add .DS_Store to .gitignore.

image

image

@katxiao katxiao requested a review from a team as a code owner March 23, 2022 18:44
@katxiao katxiao requested review from fealho and amontanez24 and removed request for a team March 23, 2022 18:44
@codecov-commenter
Copy link

Codecov Report

Merging #742 (455c18e) into master (4232f12) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #742   +/-   ##
=======================================
  Coverage   67.47%   67.47%           
=======================================
  Files          38       38           
  Lines        2832     2832           
=======================================
  Hits         1911     1911           
  Misses        921      921           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4232f12...455c18e. Read the comment docs.

Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you attach an image of the new generated docs to the PR? Otherwise LGTM :shipit:

@katxiao
Copy link
Contributor Author

katxiao commented Mar 24, 2022

Can you attach an image of the new generated docs to the PR? Otherwise LGTM :shipit:

Sounds good, just added

@katxiao katxiao merged commit d8ff924 into master Mar 24, 2022
@katxiao katxiao deleted the issue-740-add-sampling-api branch March 24, 2022 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sdv.sampling module is missing from the API
3 participants