Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning when unable to turn off rounding scheme for a column #2279

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

fealho
Copy link
Member

@fealho fealho commented Nov 5, 2024

CU-86b2jarvu, Resolve #2266.

@sdv-team
Copy link
Contributor

sdv-team commented Nov 5, 2024

@fealho fealho force-pushed the issue-2266-rounding-warning branch from e8f78be to 863b29e Compare November 6, 2024 17:39
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.65%. Comparing base (315266f) to head (863b29e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2279      +/-   ##
==========================================
+ Coverage   98.64%   98.65%   +0.01%     
==========================================
  Files          58       58              
  Lines        6035     6041       +6     
==========================================
+ Hits         5953     5960       +7     
+ Misses         82       81       -1     
Flag Coverage Δ
integration 82.23% <100.00%> (+0.03%) ⬆️
unit 97.46% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fealho fealho marked this pull request as ready for review November 6, 2024 18:22
@fealho fealho requested a review from a team as a code owner November 6, 2024 18:22
@fealho fealho requested review from gsheni and removed request for a team November 6, 2024 18:22
@fealho fealho requested a review from frances-h November 6, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to turn off rounding scheme for a column (need a warning)
2 participants