Convert integer column names to strings to allow for default column names #1976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lajohn4747
changed the title
R-Palazzo
reviewed
May 2, 2024
Contributor
R-Palazzo
left a comment
R-Palazzo
left a comment
There was a problem hiding this comment.
Looks good!
Can you add some unit tests?
R-Palazzo
reviewed
May 7, 2024
R-Palazzo
approved these changes
May 7, 2024
Contributor
R-Palazzo
left a comment
R-Palazzo
left a comment
There was a problem hiding this comment.
Thanks for addressing the comments :)
frances-h
reviewed
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1935
CU-86b04ut1e
Handle columns that are integers
This PR allows the base synthesizer to ingest data and convert the columns into strings. When sampling, it reassigns the correct columns so the user does have different columns for synthetic data.
Please note metadata dictionaries
columnsneed to be a string.