Update multi-table dataset list #536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #536 +/- ##
==========================================
+ Coverage 75.53% 81.47% +5.93%
==========================================
Files 33 33
Lines 2825 2828 +3
==========================================
+ Hits 2134 2304 +170
+ Misses 691 524 -167
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
frances-h
reviewed
Jan 30, 2026
| package='sdv-enterprise', | ||
| ) | ||
| python -m pip install sdgym[all] | ||
| " |
Contributor
Author
There was a problem hiding this comment.
No this is a fix, it's crashing without it:
https://github.com/sdv-dev/SDGym/actions/runs/21300591626/job/61317065322
frances-h
approved these changes
Jan 30, 2026
| _write_metainfo_file(synthesizers, jobs, 'single_table', result_writer) | ||
|
|
||
| # Assert | ||
| expected_path = Path(__file__).parent.parent.parent / 'sdgym/synthesizer_descriptions.yaml' |
Contributor
There was a problem hiding this comment.
Instead of chaining the parent attribute I think you can do parents[2].
rwedge
approved these changes
Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #535