Fix NotImplementedError when using FloatFormatter with numerical data types during fit due to PyArrow
#887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fealho
force-pushed
the
issue-886-pyarrow
branch
from
274373e
to
30c749c
Compare
gsheni
reviewed
Oct 4, 2024
fealho
requested review from
gsheni and
pvk-developer
and removed request for
a team
gsheni
reviewed
Oct 4, 2024
fealho
force-pushed
the
issue-886-pyarrow
branch
3 times, most recently
from
b5b9e4e
to
db5bd0a
Compare
fealho
force-pushed
the
issue-886-pyarrow
branch
from
db5bd0a
to
85bcb01
Compare
fealho
force-pushed
the
issue-886-pyarrow
branch
from
72e5f50
to
a28f04a
Compare
|
I think some tests are still failing @fealho |
fealho
force-pushed
the
issue-886-pyarrow
branch
2 times, most recently
from
5194fcb
to
dd0eff2
Compare
fealho
force-pushed
the
issue-886-pyarrow
branch
from
dd0eff2
to
00e7e0d
Compare
pvk-developer
approved these changes
Oct 16, 2024
gsheni
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CU-86b2bhp27, Resolve #886.