Make GaussianNormalizer distribution names consistent with scipy
#722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #722 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 17 17
Lines 1805 1808 +3
=========================================
+ Hits 1805 1808 +3
☔ View full report in Codecov by Sentry. |
rwedge
reviewed
Oct 17, 2023
rdt/transformers/numerical.py
Outdated
Comment on lines
296
to
298
| 'gaussian': univariate.GaussianUnivariate, | ||
| 'student_t': univariate.StudentTUnivariate, | ||
| 'truncated_gaussian': univariate.TruncatedGaussian, |
There was a problem hiding this comment.
if in the init we replaced the deprecated distribution string with the new one before calling this method we could remove the deprecated mappings from this dictionary
There was a problem hiding this comment.
That's a good suggestion, thanks.
rwedge
approved these changes
Oct 17, 2023
| @@ -311,6 +316,15 @@ def __init__(self, model_missing_values=None, learn_rounding_scheme=False, | |||
|
|
|||
| self._distributions = self._get_distributions() | |||
| if isinstance(distribution, str): | |||
| if distribution in {'gaussian', 'student_t', 'truncated_gaussian'}: | |||
There was a problem hiding this comment.
Suggested change
| if distribution in {'gaussian', 'student_t', 'truncated_gaussian'}: | |
| if distribution in self._DEPRECATED_DISTRIBUTIONS_MAPPING: |
pvk-developer
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #656.