Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve user warnings and logic for update_sdtype #705

Merged
merged 3 commits into from
Sep 14, 2023

Conversation

R-Palazzo
Copy link
Contributor

Resolve #684

@R-Palazzo R-Palazzo requested a review from a team as a code owner September 6, 2023 13:35
@R-Palazzo R-Palazzo removed the request for review from a team September 6, 2023 13:35
@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0cb92e8) 100.00% compared to head (0cb92e8) 100.00%.
Report is 1 commits behind head on multi-column-transformer.

❗ Current head 0cb92e8 differs from pull request most recent head 5cd2be7. Consider uploading reports for the commit 5cd2be7 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                    Coverage Diff                     @@
##           multi-column-transformer      #705   +/-   ##
==========================================================
  Coverage                    100.00%   100.00%           
==========================================================
  Files                            17        17           
  Lines                          1884      1884           
==========================================================
  Hits                           1884      1884           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@R-Palazzo R-Palazzo force-pushed the issue-686-remove_transformers branch 2 times, most recently from bac3b88 to cc18bb3 Compare September 11, 2023 08:55
@R-Palazzo R-Palazzo removed the request for review from frances-h September 11, 2023 08:56
@R-Palazzo R-Palazzo force-pushed the issue-684-update-sdtype branch 2 times, most recently from 1a438f8 to 8a9a65c Compare September 11, 2023 09:08
Base automatically changed from issue-686-remove_transformers to multi-column-transformer September 14, 2023 09:11
@R-Palazzo R-Palazzo merged commit 1a86850 into multi-column-transformer Sep 14, 2023
45 of 46 checks passed
@R-Palazzo R-Palazzo deleted the issue-684-update-sdtype branch September 14, 2023 11:45
R-Palazzo added a commit that referenced this pull request Sep 14, 2023
* update sdtype

* improve for boucle

* coverage
R-Palazzo added a commit that referenced this pull request Sep 20, 2023
* update sdtype

* improve for boucle

* coverage
R-Palazzo added a commit that referenced this pull request Oct 27, 2023
* update sdtype

* improve for boucle

* coverage
R-Palazzo added a commit that referenced this pull request Oct 31, 2023
* update sdtype

* improve for boucle

* coverage
R-Palazzo added a commit that referenced this pull request Oct 31, 2023
* update sdtype

* improve for boucle

* coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants