Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default to 0 if entire column is null #640

Merged
merged 1 commit into from
Apr 28, 2023
Merged

Default to 0 if entire column is null #640

merged 1 commit into from
Apr 28, 2023

Conversation

frances-h
Copy link
Contributor

Resolve #637

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (0eb2094) 100.00% compared to head (1fd6a11) 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files 
@@            Coverage Diff            @@
##            master      #640   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines         1573      1574    +1     
=========================================
+ Hits          1573      1574    +1
Impacted Files Coverage Δ
rdt/transformers/null.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@frances-h frances-h marked this pull request as ready for review April 27, 2023 14:27
@frances-h frances-h requested a review from a team as a code owner April 27, 2023 14:27
@frances-h frances-h requested review from amontanez24 and fealho and removed request for a team April 27, 2023 14:27
amontanez24
amontanez24 approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@frances-h frances-h merged commit 2ac96e5 into master Apr 28, 2023
@frances-h frances-h deleted the issue-637-crash-if-null branch April 28, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fealho fealho fealho approved these changes

@amontanez24 amontanez24 amontanez24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Numerical & datetime transformers crash if the entire column is null
4 participants
@frances-h @codecov-commenter @amontanez24 @fealho