Fix learn_rounding_scheme for more than 14 digits
#591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fealho
requested review from
pvk-developer and
amontanez24
and removed request for
a team
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #591 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 17 17
Lines 1467 1474 +7
=========================================
+ Hits 1467 1474 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
amontanez24
approved these changes
Dec 5, 2022
There was a problem hiding this comment.
Good catch! I believe we used to think that returning None meant we didn't round at all, but now we have the line of code that says data.round(self._rounding_digits or 0). I think we agreed to round to the MAX_DECIMALS but I think it would also be ok to just not round in this case.
pvk-developer
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #556.