Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calling null_transformer with model_missing_values. #550

Merged
merged 1 commit into from
Sep 9, 2022

Conversation

pvk-developer
Copy link
Member

Fix calling the NullTransformer when model_missing_values is set to True on the UnixTimestampEncoder and other datetime related transformers.

@pvk-developer pvk-developer requested a review from a team as a code owner September 9, 2022 17:23
@pvk-developer pvk-developer requested review from fealho and amontanez24 and removed request for a team and fealho September 9, 2022 17:23
@codecov-commenter
Copy link

Codecov Report

Merging #550 (74444c7) into master (857959a) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #550   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           16        16           
  Lines         1490      1490           
=========================================
  Hits          1490      1490           
Impacted Files Coverage Δ
rdt/transformers/datetime.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pvk-developer pvk-developer merged commit 3e91980 into master Sep 9, 2022
@pvk-developer pvk-developer deleted the fix-datetime-model-missing-values branch September 9, 2022 18:52
@amontanez24 amontanez24 added this to the 1.2.1 milestone Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants