Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename PIIAnonymizer AnonymizedFaker #486

Merged

Conversation

pvk-developer
Copy link
Member

Resolve #483

@pvk-developer pvk-developer requested a review from a team as a code owner April 11, 2022 13:43
@pvk-developer pvk-developer requested review from amontanez24 and fealho and removed request for a team April 11, 2022 13:43
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no references in the README.md or CONTRIBUTING.rst to the PIITransformer right? If not this looks good to go!

@pvk-developer
Copy link
Member Author

There are no references in the README.md or CONTRIBUTING.rst to the PIITransformer right? If not this looks good to go!

Not in the library, there are on the gitbook.

@amontanez24
Copy link
Contributor

There are no references in the README.md or CONTRIBUTING.rst to the PIITransformer right? If not this looks good to go!

Not in the library, there are on the gitbook.

That's fine, don't worry about the gitbook

@pvk-developer pvk-developer merged commit d37ba4e into v1.0.0.dev Apr 12, 2022
@pvk-developer pvk-developer deleted the issue-483-rename-piianonymizer-anonymizedfaker branch April 12, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants