Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update FrequencyEncoder #386

Merged
merged 8 commits into from
Feb 14, 2022
Merged

Update FrequencyEncoder #386

merged 8 commits into from
Feb 14, 2022

Conversation

fealho
Copy link
Member

@fealho fealho commented Feb 8, 2022

Resolve #364.

@fealho fealho changed the base branch from master to v1.0.0.dev February 8, 2022 16:35
@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2022 •
edited
Loading

Codecov Report

Merging #386 (c95cb0f) into v1.0.0.dev (ab60240) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           v1.0.0.dev      #386   +/-   ##
============================================
  Coverage      100.00%   100.00%           
============================================
  Files              12        12           
  Lines             944       944           
============================================
  Hits              944       944
Impacted Files Coverage Δ
rdt/hyper_transformer.py 100.00% <ø> (ø)
rdt/transformers/__init__.py 100.00% <100.00%> (ø)
rdt/transformers/categorical.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab60240...c95cb0f. Read the comment docs.

amontanez24
amontanez24 reviewed Feb 9, 2022
View reviewed changes
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Just pending on what @npatki says

rdt/transformers/categorical.py Show resolved Hide resolved
@fealho fealho marked this pull request as ready for review February 11, 2022 22:59
@fealho fealho requested a review from a team as a code owner February 11, 2022 22:59
@fealho fealho requested review from amontanez24 and removed request for a team February 11, 2022 22:59
pvk-developer
pvk-developer reviewed Feb 14, 2022
View reviewed changes
rdt/transformers/categorical.py

Args:
data (pandas.Series):
Data to fit the transformer to.
"""
self.mapping = {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

pvk-developer
pvk-developer approved these changes Feb 14, 2022
View reviewed changes
Copy link
Member

@pvk-developer pvk-developer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I left a couple of comments, but those are minor.

rdt/transformers/categorical.py Outdated Show resolved Hide resolved
tests/unit/transformers/test_categorical.py Outdated Show resolved Hide resolved
tests/unit/transformers/test_categorical.py Outdated Show resolved Hide resolved
amontanez24
amontanez24 approved these changes Feb 14, 2022
View reviewed changes
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after addressing @pvk-developer's comments

@fealho fealho merged commit 2188a30 into v1.0.0.dev Feb 14, 2022
@fealho fealho deleted the issue-364-frequency-encoder branch February 14, 2022 21:44
pvk-developer pushed a commit that referenced this pull request Feb 28, 2022
@fealho @pvk-developer
Update FrequencyEncoder (#386)
a6da599 
* Rename transformer

* Update CategoricalTransformer

* Change history

* Rename tests

* Bad implementation that works

* Complete overhaul of the code

* Vectorize _transform

* Limit warning messages to 5 elements per warning
amontanez24 pushed a commit that referenced this pull request Mar 7, 2022
@fealho @amontanez24
Update FrequencyEncoder (#386)
bc6aa44 
* Rename transformer

* Update CategoricalTransformer

* Change history

* Rename tests

* Bad implementation that works

* Complete overhaul of the code

* Vectorize _transform

* Limit warning messages to 5 elements per warning
amontanez24 pushed a commit that referenced this pull request Apr 21, 2022
@fealho @amontanez24
Update FrequencyEncoder (#386)
cd9874d 
* Rename transformer

* Update CategoricalTransformer

* Change history

* Rename tests

* Bad implementation that works

* Complete overhaul of the code

* Vectorize _transform

* Limit warning messages to 5 elements per warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npatki npatki npatki left review comments

@pvk-developer pvk-developer pvk-developer approved these changes

@amontanez24 amontanez24 amontanez24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update CategoricalTransformer to make it user friendly
5 participants
@fealho @codecov-commenter @npatki @amontanez24 @pvk-developer