Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete unnecessary transformers #379

Merged
merged 3 commits into from
Feb 3, 2022
Merged

Delete unnecessary transformers #379

merged 3 commits into from
Feb 3, 2022

Conversation

fealho
Copy link
Member

@fealho fealho commented Feb 2, 2022

Resolve #373.

@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2022 •
edited
Loading

Codecov Report

Merging #379 (0bd062a) into v1.0.0.dev (52bc231) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           v1.0.0.dev      #379   +/-   ##
============================================
  Coverage      100.00%   100.00%           
============================================
  Files              12        12           
  Lines             954       949    -5     
============================================
- Hits              954       949    -5
Impacted Files Coverage Δ
rdt/transformers/categorical.py 100.00% <ø> (ø)
rdt/transformers/numerical.py 100.00% <ø> (ø)
rdt/transformers/base.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52bc231...0bd062a. Read the comment docs.

@fealho fealho changed the base branch from master to v1.0.0.dev February 2, 2022 03:46
@fealho fealho marked this pull request as ready for review February 2, 2022 22:06
@fealho fealho requested a review from a team as a code owner February 2, 2022 22:06
@fealho fealho requested review from pvk-developer, amontanez24 and a team and removed request for a team February 2, 2022 22:06
pvk-developer
pvk-developer approved these changes Feb 3, 2022
View reviewed changes
Copy link
Member

@pvk-developer pvk-developer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

amontanez24
amontanez24 approved these changes Feb 3, 2022
View reviewed changes
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@fealho fealho merged commit 9507870 into v1.0.0.dev Feb 3, 2022
@fealho fealho deleted the issue-373-delete-transformers branch February 3, 2022 18:10
pvk-developer pushed a commit that referenced this pull request Feb 28, 2022
@fealho @pvk-developer
Delete unnecessary transformers (#379)
ab0a5f6 
* Remove transformers

* Remove prints

* Lower TEST_THRESHOLD
amontanez24 pushed a commit that referenced this pull request Mar 7, 2022
@fealho @amontanez24
Delete unnecessary transformers (#379)
381ded1 
* Remove transformers

* Remove prints

* Lower TEST_THRESHOLD
amontanez24 pushed a commit that referenced this pull request Apr 21, 2022
@fealho @amontanez24
Delete unnecessary transformers (#379)
82f8db8 
* Remove transformers

* Remove prints

* Lower TEST_THRESHOLD
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvk-developer pvk-developer pvk-developer approved these changes

@amontanez24 amontanez24 amontanez24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Delete unnecessary transformers
4 participants
@fealho @codecov-commenter @amontanez24 @pvk-developer