Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create validate_transformer_quality function #299

Merged
merged 1 commit into from
Oct 19, 2021
Merged

Create validate_transformer_quality function #299

merged 1 commit into from
Oct 19, 2021

Conversation

amontanez24
Copy link
Contributor

@amontanez24 amontanez24 commented Oct 19, 2021 •
edited
Loading

resolves #253

Example use:

>>> validate_transformer_quality(CategoricalTransformer)
Validating Quality Tests for transformer CategoricalTransformer

SUCCESS: The quality tests were successful.

Dataset                    Score    Compared To Average  Acceptable
----------------------  --------  ---------------------  ------------
adult                   0.223325               0.442723  True
student_placements      0.45749                0.994534  True
student_placements_pii  0.45749                0.982039  True

@amontanez24 amontanez24 requested a review from a team as a code owner October 19, 2021 00:34
@amontanez24 amontanez24 requested review from katxiao and removed request for a team October 19, 2021 00:34
@amontanez24 amontanez24 changed the base branch from master to v0.6.0-dev October 19, 2021 00:34
csala
csala approved these changes Oct 19, 2021
View reviewed changes
Copy link
Contributor

@csala csala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment about a docstring that seems incorrect.
Other than that, this looks good to go

tests/contributing.py Outdated Show resolved Hide resolved
tests/contributing.py Outdated
transformer (string or rdt.transformers.BaseTransformer):
The transformer to validate.
Output:
bool:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like this is not describing the actual output.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@amontanez24 amontanez24 force-pushed the issue-253-validate-transformer-quality branch from b546573 to 0f74856 Compare October 19, 2021 18:26
@codecov-commenter
Copy link

Codecov Report

Merging #299 (0f74856) into v0.6.0-dev (9b118c4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           v0.6.0-dev     #299   +/-   ##
===========================================
  Coverage       81.81%   81.81%           
===========================================
  Files              11       11           
  Lines             825      825           
===========================================
  Hits              675      675           
  Misses            150      150

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b118c4...0f74856. Read the comment docs.

@amontanez24 amontanez24 merged commit f8085b8 into v0.6.0-dev Oct 19, 2021
@amontanez24 amontanez24 deleted the issue-253-validate-transformer-quality branch October 19, 2021 18:56
amontanez24 added a commit that referenced this pull request Oct 26, 2021
@amontanez24
Create validate_transformer_quality function (#299)
566408f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csala csala csala approved these changes

@katxiao katxiao katxiao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create validate_transformer_quality function
4 participants
@amontanez24 @codecov-commenter @katxiao @csala