Update baseclass fixes #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## update-baseclass #242 +/- ##
===================================================
Coverage ? 93.19%
===================================================
Files ? 9
Lines ? 647
Branches ? 0
===================================================
Hits ? 603
Misses ? 44
Partials ? 0 Continue to review full report at Codecov.
|
fealho
force-pushed
the
update-baseclass-fixes
branch
from
8ca9818
to
834a461
Compare
fealho
force-pushed
the
update-baseclass
branch
from
4833ab6
to
2796fa6
Compare
fealho
added a commit
that referenced
this pull request
Sep 22, 2021
* Updates the baseclass * Addresses feedback * Makes get_input_type a class method * Fix documentation * Fix one line bug * Various improvements + some test cases * Create _add_prefix * Return data if columns not in data * Multiple improvements + test cases * Added test cases * Fix lint * Remove test cases. * Fix a bunch of bugs * Addresses feedback * Update baseclass fixes (#242) * Implement basic integration tests for BaseTransformer * Fix failing tests * Fix lint and disable some PyLint warnings * Fix lint + general improvements * Fix merge conflicts * Fix lint Co-authored-by: Carles Sala <carles@pythiac.com>
csala
added a commit
that referenced
this pull request
Sep 27, 2021
* Implement basic integration tests for BaseTransformer * Fix failing tests * Fix lint and disable some PyLint warnings
fealho
added a commit
that referenced
this pull request
Sep 27, 2021
* Updates the baseclass * Update numerical transformer * Addresses feedback * Makes get_input_type a class method * Fix documentation * Fix one line bug * Various improvements + some test cases * Create _add_prefix * Return data if columns not in data * Multiple improvements + test cases * Added test cases * Fix lint * Remove test cases. * Fix a bunch of bugs * Addresses feedback * Update baseclass fixes (#242) * Implement basic integration tests for BaseTransformer * Fix failing tests * Fix lint and disable some PyLint warnings * Fix lint + general improvements * Fix merge conflicts * Fix lint * Update datatypes. * Updates numerical transformer to match new base class transformer * Fixes numerical transformer and unit tests * Add is_composition_identity * Fix setup.cfg pyling disable syntax * Fix performance bug Co-authored-by: Carles Sala <carles@pythiac.com> Co-authored-by: Carles Sala <carles@sdv.dev>
fealho
added a commit
that referenced
this pull request
Sep 28, 2021
* Updates the baseclass * Update categorical transformers * Addresses feedback * Makes get_input_type a class method * Fix documentation * Fix one line bug * Various improvements + some test cases * Create _add_prefix * Return data if columns not in data * Multiple improvements + test cases * Added test cases * Fix lint * Remove test cases. * Fix a bunch of bugs * Addresses feedback * Update baseclass fixes (#242) * Implement basic integration tests for BaseTransformer * Fix failing tests * Fix lint and disable some PyLint warnings * Fix lint + general improvements * Fix merge conflicts * Fix lint * Tentative updates * Fix categorical * Working version of categorical (only hypertransformer fails) * Fix lint * Fix lint * Fix small errors * Lint * Fix small errors * Fix hypertransformer * Address feedback * Fix lint Co-authored-by: Carles Sala <carles@pythiac.com>
csala
added a commit
that referenced
this pull request
Oct 13, 2021
* Updates the baseclass * Addresses feedback * Makes get_input_type a class method * Fix documentation * Fix one line bug * Various improvements + some test cases * Create _add_prefix * Return data if columns not in data * Multiple improvements + test cases * Added test cases * Fix lint * Remove test cases. * Fix a bunch of bugs * Addresses feedback * Update baseclass fixes (#242) * Implement basic integration tests for BaseTransformer * Fix failing tests * Fix lint and disable some PyLint warnings * Fix lint + general improvements * Fix merge conflicts * Fix lint Co-authored-by: Carles Sala <carles@pythiac.com>
csala
added a commit
that referenced
this pull request
Oct 13, 2021
* Updates the baseclass * Update numerical transformer * Addresses feedback * Makes get_input_type a class method * Fix documentation * Fix one line bug * Various improvements + some test cases * Create _add_prefix * Return data if columns not in data * Multiple improvements + test cases * Added test cases * Fix lint * Remove test cases. * Fix a bunch of bugs * Addresses feedback * Update baseclass fixes (#242) * Implement basic integration tests for BaseTransformer * Fix failing tests * Fix lint and disable some PyLint warnings * Fix lint + general improvements * Fix merge conflicts * Fix lint * Update datatypes. * Updates numerical transformer to match new base class transformer * Fixes numerical transformer and unit tests * Add is_composition_identity * Fix setup.cfg pyling disable syntax * Fix performance bug Co-authored-by: Carles Sala <carles@pythiac.com> Co-authored-by: Carles Sala <carles@sdv.dev>
csala
added a commit
that referenced
this pull request
Oct 13, 2021
* Updates the baseclass * Update categorical transformers * Addresses feedback * Makes get_input_type a class method * Fix documentation * Fix one line bug * Various improvements + some test cases * Create _add_prefix * Return data if columns not in data * Multiple improvements + test cases * Added test cases * Fix lint * Remove test cases. * Fix a bunch of bugs * Addresses feedback * Update baseclass fixes (#242) * Implement basic integration tests for BaseTransformer * Fix failing tests * Fix lint and disable some PyLint warnings * Fix lint + general improvements * Fix merge conflicts * Fix lint * Tentative updates * Fix categorical * Working version of categorical (only hypertransformer fails) * Fix lint * Fix lint * Fix small errors * Lint * Fix small errors * Fix hypertransformer * Address feedback * Fix lint Co-authored-by: Carles Sala <carles@pythiac.com>
amontanez24
pushed a commit
that referenced
this pull request
Oct 26, 2021
* Updates the baseclass * Addresses feedback * Makes get_input_type a class method * Fix documentation * Fix one line bug * Various improvements + some test cases * Create _add_prefix * Return data if columns not in data * Multiple improvements + test cases * Added test cases * Fix lint * Remove test cases. * Fix a bunch of bugs * Addresses feedback * Update baseclass fixes (#242) * Implement basic integration tests for BaseTransformer * Fix failing tests * Fix lint and disable some PyLint warnings * Fix lint + general improvements * Fix merge conflicts * Fix lint Co-authored-by: Carles Sala <carles@pythiac.com>
amontanez24
pushed a commit
that referenced
this pull request
Oct 26, 2021
* Updates the baseclass * Update numerical transformer * Addresses feedback * Makes get_input_type a class method * Fix documentation * Fix one line bug * Various improvements + some test cases * Create _add_prefix * Return data if columns not in data * Multiple improvements + test cases * Added test cases * Fix lint * Remove test cases. * Fix a bunch of bugs * Addresses feedback * Update baseclass fixes (#242) * Implement basic integration tests for BaseTransformer * Fix failing tests * Fix lint and disable some PyLint warnings * Fix lint + general improvements * Fix merge conflicts * Fix lint * Update datatypes. * Updates numerical transformer to match new base class transformer * Fixes numerical transformer and unit tests * Add is_composition_identity * Fix setup.cfg pyling disable syntax * Fix performance bug Co-authored-by: Carles Sala <carles@pythiac.com> Co-authored-by: Carles Sala <carles@sdv.dev>
amontanez24
pushed a commit
that referenced
this pull request
Oct 26, 2021
* Updates the baseclass * Update categorical transformers * Addresses feedback * Makes get_input_type a class method * Fix documentation * Fix one line bug * Various improvements + some test cases * Create _add_prefix * Return data if columns not in data * Multiple improvements + test cases * Added test cases * Fix lint * Remove test cases. * Fix a bunch of bugs * Addresses feedback * Update baseclass fixes (#242) * Implement basic integration tests for BaseTransformer * Fix failing tests * Fix lint and disable some PyLint warnings * Fix lint + general improvements * Fix merge conflicts * Fix lint * Tentative updates * Fix categorical * Working version of categorical (only hypertransformer fails) * Fix lint * Fix lint * Fix small errors * Lint * Fix small errors * Fix hypertransformer * Address feedback * Fix lint Co-authored-by: Carles Sala <carles@pythiac.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add basic integration tests for the BaseTransformer and fix/adapt all the tests that failed because of the BaseTransformer changes.
Also fix minor lint issues and re-configure PyLint to avoid warnings about expected or acceptable things.