-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create ways for HyperTransformer to know which transformers to apply to each data type #232 #239
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
a2b9ce4
adding get_transformers_by_type function
amontanez24 cc9c38c
adding other attributes and fixing typo
amontanez24 4fb6e15
lint issues
amontanez24 fbda538
pr comments
amontanez24 d4b7da6
adding default transformers method
amontanez24 857ade7
pr comments
amontanez24 86f238a
sorting error
amontanez24 69ee13d
adding caching and some cleanup
amontanez24 9b2c4f6
lint error
amontanez24 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
"""BaseTransformer module.""" | ||
import abc | ||
|
||
|
||
class BaseTransformer: | ||
|
@@ -20,6 +21,23 @@ class BaseTransformer: | |
_column_prefix = None | ||
_output_columns = None | ||
|
||
@classmethod | ||
def get_subclasses(cls): | ||
"""Recursively find subclasses of this Baseline. | ||
|
||
Returns: | ||
list: | ||
List of all subclasses of this class. | ||
""" | ||
subclasses = [] | ||
for subclass in cls.__subclasses__(): | ||
if abc.ABC not in subclass.__bases__: | ||
subclasses.append(subclass) | ||
|
||
subclasses += subclass.get_subclasses() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we add a blank line above this one? |
||
|
||
return subclasses | ||
|
||
@classmethod | ||
def get_input_type(cls): | ||
"""Return the input type supported by the transformer. | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if
functools
is part of the standard library. If it is not, we should add it tosetup.py
, even if we already install it because one of our dependencies use it, so if they remove it in the future we do not crash.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is part of the standard library