Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update boolean transformer #228

Merged
merged 7 commits into from
Sep 24, 2021
Merged

Update boolean transformer #228

merged 7 commits into from
Sep 24, 2021

Conversation

fealho
Copy link
Member

@fealho fealho commented Sep 20, 2021

No description provided.

@csala csala force-pushed the update-boolean-transformer branch 2 times, most recently from 55437c8 to 5f994f9 Compare September 23, 2021 18:24
@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2021

Codecov Report

Merging #228 (e5301e5) into v0.6.0-dev (03ecfec) will increase coverage by 0.37%.
The diff coverage is 96.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##           v0.6.0-dev     #228      +/-   ##
==============================================
+ Coverage       93.07%   93.45%   +0.37%     
==============================================
  Files               9        9              
  Lines             650      672      +22     
==============================================
+ Hits              605      628      +23     
+ Misses             45       44       -1     
Impacted Files Coverage Δ
rdt/transformers/base.py 82.95% <89.47%> (ø)
rdt/hyper_transformer.py 100.00% <100.00%> (ø)
rdt/transformers/boolean.py 100.00% <100.00%> (ø)
rdt/transformers/null.py 98.07% <0.00%> (+1.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03ecfec...e5301e5. Read the comment docs.

@csala csala marked this pull request as ready for review September 24, 2021 12:07
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fealho fealho requested review from csala and removed request for katxiao September 24, 2021 16:15
@fealho fealho merged commit ef2bb78 into v0.6.0-dev Sep 24, 2021
@fealho fealho deleted the update-boolean-transformer branch September 24, 2021 16:20
csala added a commit that referenced this pull request Oct 13, 2021
* Update boolean transformer

* Adapt the BooleanTransformer to the new BaseTransformer

* Temporarily support both new and old style transformers

* Make columns attributes public

* Temporarily support old and new style datasets

* Test new-style transformers properly

* Temporarily disable W0212 PyLint warning

Co-authored-by: Carles Sala <carles@pythiac.com>
amontanez24 pushed a commit that referenced this pull request Oct 26, 2021
* Update boolean transformer

* Adapt the BooleanTransformer to the new BaseTransformer

* Temporarily support both new and old style transformers

* Make columns attributes public

* Temporarily support old and new style datasets

* Test new-style transformers properly

* Temporarily disable W0212 PyLint warning

Co-authored-by: Carles Sala <carles@pythiac.com>
@amontanez24 amontanez24 added this to the 0.6.0 milestone Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants