Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ways for HyperTransformer to know which transformers to apply to each data type #232

Closed
amontanez24 opened this issue Sep 20, 2021 · 1 comment · Fixed by #239
Closed
Assignees
Labels
feature request Request for a new feature
Milestone

Comments

@amontanez24
Copy link
Contributor

Problem Description

Since RDT will be expanding the number of data types it supports, we will need a new way for the HyperTransformer to determine which transformers to apply to a specific data type. We propose the following additions:

  1. A function, get_transformers_by_type, which iterates over all the existing Transformers and calls the get_input_type method to create a dictionary that indicates which transformers work with which data type.
  2. A DEFAULT_TRANSFORMERS dict which may indicate what the default transformer for each data type is.
  3. If a data type is not in the DEFAULT_TRANSFORMERS dictionary, the first transformer found is "the default".
@amontanez24 amontanez24 added feature request Request for a new feature pending review labels Sep 20, 2021
amontanez24 added a commit that referenced this issue Sep 24, 2021
…to each data type #232 (#239)

* adding get_transformers_by_type function

* adding other attributes and fixing typo

* pr comments

* adding default transformers method

* pr comments

* adding caching and some cleanup
@kveerama
Copy link
Contributor

@amontanez24 in the above formulation, would this method in hypertransformer simply return a transformer which can process the input_type regardless whether or not that transformer output_type is ready for ML or not?

csala pushed a commit that referenced this issue Oct 13, 2021
…to each data type #232 (#239)

* adding get_transformers_by_type function

* adding other attributes and fixing typo

* pr comments

* adding default transformers method

* pr comments

* adding caching and some cleanup
amontanez24 added a commit that referenced this issue Oct 26, 2021
…to each data type #232 (#239)

* adding get_transformers_by_type function

* adding other attributes and fixing typo

* pr comments

* adding default transformers method

* pr comments

* adding caching and some cleanup
@amontanez24 amontanez24 self-assigned this Oct 26, 2021
@amontanez24 amontanez24 added this to the 0.6.0 milestone Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature
Projects
None yet
3 participants