Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only run unit and integration tests on oldest and latest python versions for macos #406

Merged
merged 4 commits into from
May 1, 2024

Conversation

R-Palazzo
Copy link
Contributor

CU-86b07h928
Resolve #405

@R-Palazzo R-Palazzo requested a review from a team as a code owner April 29, 2024 13:39
@sdv-team
Copy link
Contributor

@R-Palazzo R-Palazzo removed the request for review from a team April 29, 2024 13:39
Copy link
Collaborator

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small change

pyproject.toml Outdated
"pandas>=1.5.0;python_version>='3.11' and python_version<'3.12'",
"pandas>=2.1.1;python_version>='3.12'",
'plotly>=5.10.0',
"scipy>=1.5.4;python_version<'3.10'",
"scipy>=1.8.0;python_version<'3.10'",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like version 1.7.3 of scipy has arm support

Copy link
Contributor

@lajohn4747 lajohn4747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we leave a comment about only testing latest and earliest mac?

@R-Palazzo R-Palazzo merged commit d6a3bdc into main May 1, 2024
64 checks passed
@R-Palazzo R-Palazzo deleted the issue-405-macos-workflow branch May 1, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only run unit and integration tests on oldest and latest python versions for macos
4 participants