Package Maintenance Update #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvk-developer
requested review from
fealho,
amontanez24 and
npatki
and removed request for
a team and
fealho
npatki
approved these changes
Dec 20, 2022
docs/conf.py
Outdated
| copyright = '2018, MIT Data To AI Lab' | ||
| author = 'MIT Data To AI Lab' | ||
| copyright = '2022, DataCebo Inc.' | ||
| author = 'DataCebo, Inc.' | ||
| description = 'A library to model multivariate data using copulas.' |
There was a problem hiding this comment.
I think we can use the same description as we use for the setup.py file --
'Create tabular synthetic data using copulas-based modeling'
amontanez24
reviewed
Dec 20, 2022
| @@ -87,7 +87,7 @@ | |||
| ] | |||
|
|
|||
| tutorials_require = [ | |||
| 'scikit-learn>=0.24,<2', | |||
| 'scikit-learn>=0.24,<1.2', | |||
There was a problem hiding this comment.
any reason we changed this?
There was a problem hiding this comment.
Yes, the tutorials are not working since the demo datasets used are available until 1.2
Since this was for tutorials only I think it was okay to just cap it right away.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #336