Add Python 3.12 support #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Task linked: CU-86ayu7163 CTGAN - Support Python 3.12 #324 |
fealho
force-pushed
the
issue-324-py12
branch
2 times, most recently
from
b8cacc2
to
bdc261c
Compare
fealho
requested review from
amontanez24 and
pvk-developer
and removed request for
a team
Comment on lines
1
to
5
| [tox] | ||
| envlist = py39-lint, py3{8,9,10,11}-{unit,integration,readme} | ||
| envlist = py39-lint, py3{8,9,10,11,12}-{unit,integration,readme} | ||
|
|
||
| [testenv] | ||
| skipsdist = false |
There was a problem hiding this comment.
Do we even use tox.ini anymore ? If not I think we can remove it
There was a problem hiding this comment.
The makefile commands clean-test and test-all use tox.
pvk-developer
approved these changes
Apr 8, 2024
amontanez24
reviewed
Apr 8, 2024
| @@ -57,7 +57,7 @@ def _get_minimum_versions(dependencies, python_version): | |||
| for dependency in dependencies: | |||
| if '@' in dependency: | |||
| name, url = dependency.split(' @ ') | |||
| min_versions[name] = f'{name} @ {url}' | |||
| min_versions[name] = f'{url}#egg={name}' | |||
There was a problem hiding this comment.
@R-Palazzo Is there anything else that should be done here?
There was a problem hiding this comment.
amontanez24
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CU-86ayu7163, Resolve #324.