BOSS DRP IDLspec2D v6_2+ paths added #94
Conversation
update boss paths for IDLspec2D v6_2_0 and later which includes a restructuring of the output file structure. New special functions are used to maintain backwards compatibility
| spArc = $BOSS_SPECTRO_REDUX/{run2d}/@sptypefolder|/@fieldgrp|/@pad_fieldid|@isplate|/spArc-{br}{id}-{frame:0>8}.fits.gz | ||
| spCFrame = $BOSS_SPECTRO_REDUX/{run2d}/@sptypefolder|/@fieldgrp|/@pad_fieldid|@isplate|/spCFrame-{br}{id}-{frame:0>8}.fits.gz |
There was a problem hiding this comment.
I'm guessing for backwards compatibility, sptypefolder and fieldgrp functions will return empty strings.
There was a problem hiding this comment.
yes, that is correct.
| specFull_coadd = $BOSS_SPECTRO_REDUX/{run2d}/spectra/full/{coadd}/{mjd}/spec-{coadd}-{mjd}-{catalogid}.fits | ||
| spAllField_coadd = $BOSS_SPECTRO_REDUX/{run2d}/spectra/full/{coadd}/{mjd}/spAll-{coadd}-{mjd}.fits | ||
| spAllLineField_coadd = $BOSS_SPECTRO_REDUX/{run2d}/spectra/full/{coadd}/{mjd}/spAllLine-{coadd}-{mjd}.fits | ||
| spCOADDS = $BOSS_SPECTRO_REDUX/{run2d}/@spcoaddfolder|/{phase}_{survey}_COADDS.par |
There was a problem hiding this comment.
Does this name need to be in all caps? Not necessarily suggesting we change it though.
There was a problem hiding this comment.
It does not, however, the name matches the name of the data model.
| spAllLineField_epoch = $BOSS_SPECTRO_REDUX/{run2d}/epoch/spectra/full/@pad_fieldid|@isplate|/{mjd}/spAllLine-@pad_fieldid|-{mjd}.fits | ||
| sciExp = $BOSS_SPECTRO_REDUX/{run2d}/@sptypefolder|/@fieldgrp|/@pad_fieldid|@isplate|/SciExp-@pad_fieldid|.par | ||
| spPlancombepoch = $BOSS_SPECTRO_REDUX/{run2d}/@sptypefolder|/@fieldgrp|/@pad_fieldid|@isplate|/epoch/spPlancombepoch-@pad_fieldid|-{mjd}.par | ||
| fieldlist_epoch = $BOSS_SPECTRO_REDUX/{run2d}/@sptypefolder|/fieldlist-{run2d}@epochflag|.fits |
There was a problem hiding this comment.
This change is from /epoch/ to the new sptypefolder method, which I think for some cases should return just epoch to retain backwards compatibility, but when I look at that method, it returns summary/epoch for fieldlist-epoch? I just looked at one example as a check, but want to sure all the bases are covered.
There was a problem hiding this comment.
You are correct, I missed that when I checked, since it was a valid path to the daily version. I have now fixed the special function
| @@ -271,69 +271,70 @@ sdR_N = $BOSS_SPECTRO_DATA_N/{mjd}/sdR-{br}{id}-{frame}.fit | |||
| sdR_S = $BOSS_SPECTRO_DATA_S/{mjd}/sdR-{br}{id}-{frame}.fit | |||
|
|
|||
| #boss DRP paths | |||
| spplan2d = $BOSS_SPECTRO_REDUX/{run2d}/@pad_fieldid|@isplate|/spplan2d-@pad_fieldid|-{mjd}.par | |||
| spPlancomb = $BOSS_SPECTRO_REDUX/{run2d}/@pad_fieldid|@isplate|/spPlancomb-@pad_fieldid|-{mjd}.par | |||
| spplan2d = $BOSS_SPECTRO_REDUX/{run2d}/@sptypefolder|/@fieldgrp|/@pad_fieldid|@isplate|/spPlan2d-@pad_fieldid|-{mjd}.par | |||
There was a problem hiding this comment.
does this file name change break backwards compat?
There was a problem hiding this comment.
This was incorrect previously. I have updated the IPL-3 version as well
Fix the spPlan2d path in ipl3
Made modifications to the BOSS DRP paths to be compatible with the updates in v6_2_0, while maintaining backward compatibility