Change watchdog to a single binary #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using [geckodriver](https://hg.mozilla.org/mozilla-central/file/tip/testing/geckodriver) as a refernce, this commit changes the code into a monolith binary. Imports are much easier to understand now.
This adds a new dependency `error-chain`. This package helps in easy error chaining and handling. Traceback is so easy now. Also removing the logger in the coming patches because pam_exec gives a simpler logging facility. No need of writing code for logging in rust.
fristonio
requested changes
Feb 4, 2020
src/init.rs
Outdated
| panic!("Watchdog: Couldn't open log file"); | ||
| } | ||
| }; | ||
| // pub fn init_logger(config: &Config) { |
There was a problem hiding this comment.
I should delete them. Logging will be done directly from pam_exec itself.
supra08
requested changes
Feb 5, 2020
Cargo.toml
Outdated
|
|
||
| [lib] | ||
| name = "common_lib" |
fristonio
approved these changes
Feb 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requesting reviews @fristonio @vrongmeal