Implement zhash value #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 22, 2020 08:42
|
@vrongmeal Sorry for the long time this took! The API ended up being a mix between the hash and the zset APIs. Let me know if i missed any test cases or if there are other methods you'd like to implement for this data type. |
Closed
carmo-evan
changed the title
|
Thanks @carmo-evan for the PR. @murex971 will review this :) |
murex971
requested changes
Oct 23, 2020
|
Also update the test for the insert action in |
Co-authored-by: Nupur Agrawal <46920259+murex971@users.noreply.github.com>
|
@murex971 should be good for a second review |
murex971
approved these changes
Oct 26, 2020
|
@carmo-evan thanks for the contribution:) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#13