Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kissaki #82

Merged
merged 12 commits into from
May 17, 2024
Merged

Kissaki #82

merged 12 commits into from
May 17, 2024

Conversation

izuku-sds
Copy link
Contributor

No description provided.

@ashpect
Copy link
Contributor

ashpect commented May 17, 2024

  1. Remove testing functions and irrelevant comments
  2. Allowing pushing sample challenges for now, we'll create a submodule for it later

ashpect
ashpect reviewed May 17, 2024
View reviewed changes
Copy link
Contributor

@ashpect ashpect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left comments

config.sample.toml Outdated Show resolved Hide resolved
kubernetes/manifests/_setup.yml Show resolved Hide resolved
kubernetes/manifests/kissaki.yml Outdated Show resolved Hide resolved
kubernetes/manifests/kissaki.yml Outdated Show resolved Hide resolved
kubernetes/templates/runtime/cc.yml Outdated Show resolved Hide resolved
lib/deployment/deployment.go Outdated Show resolved Hide resolved
services/challengedeployerservice/controller.go Outdated Show resolved Hide resolved
services/challengedeployerservice/controller.go Outdated Show resolved Hide resolved
izuku-sds
izuku-sds commented May 17, 2024
View reviewed changes
Copy link
Contributor Author

@izuku-sds izuku-sds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ashpect's reviews resolved in next commit

@ashpect ashpect merged commit 73763aa into develop May 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashpect ashpect ashpect left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@izuku-sds @ashpect