Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax highlight with vue-prism #17

Open
albinotonnina opened this issue Jan 3, 2018 · 3 comments
Open

Syntax highlight with vue-prism #17

albinotonnina opened this issue Jan 3, 2018 · 3 comments

Comments

@albinotonnina
Copy link

I see that the dep is there already but prism is not fully implemented.
I tried to play with it a few minutes, adding the missing prism.css and changing the markup but it wasn't coming out well. Maybe someone can take a look at it.
I think there's something also with the format of the code coming from the store.

Also, do you think is good to keep strings and code together in the store like that and have the translation files basically duplicating maybe unnecessarily the code?
Could a next iteration maybe address differently the thing? Like having the code in a different format?

@sdras
Copy link
Owner

sdras commented Jan 3, 2018

I had the syntax highlighting working, but took it out because there is no current support for the pre tag in splittext (I use this for the animation). I left it in because I was hoping to tackle it at some point, but as it's a small amount of code, it wasn't crucial to the project. If anyone wants to dig into that, I'm happy to have the help as I'm quite busy right now. It's not vital though. If you want to see how it looks set up, it's in the history in the array-explorer repo.

You are correct in assuming that the store files would no longer need the <br> and <span> tags if this was fixed.

@albinotonnina
Copy link
Author

Yes yes, nothing really vital. I may try in my free time as well or someone else at some point.

@sdras
Copy link
Owner

sdras commented Jan 3, 2018

Please feel free to :) thanks for the inquiry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants