Fixed Issue #284 Linter Cppcheck #306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9e2eec5.
dennisafa
previously approved these changes
Aug 25, 2021
twood02
added
the
ready-for-gatekeeper 🚪
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue where cppcheck will not work at each PR.
Summary:
Updated both Linter.yml and install-linters.sh to install the correct version of cppcheck. Also, made sure that cppcheck
runs-on:isubuntu-20.04rather thanubuntu-latest.Usage:
Cppcheck is used in GitHub Actions to automatically check our code at each PR.
Merging notes:
TODO before merging :
Test Plan:
Create a new PR or update existing PR to ensure that cppcheck is functioning correctly.
Review: