New device: Blackberry KEY2 LE (luna) #97
Conversation
sajattack
force-pushed
the
saj/bbry-luna-for-upstream
branch
from
bcafa30 to
7684de3
Compare
|
Please open CI (actions) checks named "Device tree validation", expand the "Analyze results" section and fix all the dt-schema validation errors that are fixable within your |
sajattack
force-pushed
the
saj/bbry-luna-for-upstream
branch
from
3d71d3e to
3b77ce1
Compare
|
All commits that are intended to go upstream should have proper descriptions in commit messages. (Commit modifying sdm660_defconfig, which is not upstream, does not qualify here). I not fully understand, you have have changed ~1300 lines in this PR, but can't type few words to describe your changes?.. For inspiration l'd suggest to look for similar commits around neighbouring files histories, or ask more questions |
|
|
||
| qcom,msm-id = <0x159 0x0>; | ||
| qcom,board-id = <0xaa000008 0x00>; | ||
| qcom,pmic-id = <0x1001b 0x101011a 0x00 0x00 0x1001b 0x201011a 0x00 0x00>; |
There was a problem hiding this comment.
Likely ll of these qcom,*-id will have to be removed before sending this upstream.
There was a problem hiding this comment.
I think it's best to keep these as long as possible.
| regulator-max-microvolt = <3300000>; | ||
| regulator-enable-ramp-delay = <250>; | ||
| regulator-allow-set-load; | ||
| regulator-always-on; |
There was a problem hiding this comment.
Are you sure your device needs this? Usually l3b is always-on only on xiaomi-sdm660 platform.
If you bindly copied regulators block from one of xiaomi devices I suggest you carefully re-check each regulator again.
There was a problem hiding this comment.
How should I check them without schematics? Just turn them off one by one and see if it still works?
There was a problem hiding this comment.
From downstream dts if you have it? (adb pull /sys/firmware/fdt)
If you don't have downstream dts then just remove regulator-always-on here and see if it works;
The change for xiaomi was originally done in 301cf4f
There was a problem hiding this comment.
Were you able to confirm regulators settings?
There was a problem hiding this comment.
made regulator settings match downstream more closely
drivers/gpu/drm/panel/panel-livata.c
Outdated
| struct device *dev = &dsi->dev; | ||
| int ret; | ||
|
|
||
| mipi_dsi_generic_write_seq(dsi, 0x00, 0x00); |
There was a problem hiding this comment.
geerate usin fresh generator, these should use new multi-functions
The mfd is already supported upstream, but not in the dt-bindings. Signed-off-by: Paul Sajna <hello@paulsajna.com>
"Livata Video Panel" used by BlackBerry KEY2 LE (luna) Signed-off-by: Paul Sajna <hello@paulsajna.com>
"Livata Video Panel" used by BlackBerry KEY2 LE (luna) Generated by mdss-panel-generator Signed-off-by: Paul Sajna <hello@paulsajna.com>
This chip variant differs from others - it has different register map and swapped rows/columns. Signed-off-by: Sergey Larin <cerg2010cerg2010@mail.ru>
That's what they referred to themselves as in downstream kernels (at least TCL ones) Signed-off-by: Paul Sajna <hello@paulsajna.com>
Add bbry,luna under supported sdm636 devices Signed-off-by: Paul Sajna <hello@paulsajna.com>
sajattack
force-pushed
the
saj/bbry-luna-for-upstream
branch
2 times, most recently
from
6b55943 to
d8f38b5
Compare
|
Can you attach dmesg of booting to OP post? |
added. |
working features: - Internal MMC - External SDcard - Wi-Fi - Bluetooth - Keypad - Panel - GPU (bit crashy) - fuel gauge - volume buttons - usb TODO: - keypad backlight - modem - audio - 3-button row - gps - fm radio - camera Signed-off-by: Paul Sajna <hello@paulsajna.com>
…erals Signed-off-by: Paul Sajna <hello@paulsajna.com>
sajattack
force-pushed
the
saj/bbry-luna-for-upstream
branch
from
d8f38b5 to
97b4208
Compare
Adds:
Updates:
dmesg.txt