Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ktlint candidate #639

Merged
merged 2 commits into from
May 7, 2023
Merged

Add ktlint candidate #639

merged 2 commits into from
May 7, 2023

Conversation

eygraber
Copy link
Contributor

No description provided.


@ChangeLog(order = "079")
class KtlintMigrations {
@ChangeSet(order = "001", id = "001_add_ktlint_candidate", author = "paul-dingemans")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be your GitHub username.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

Candidate(
candidate = "ktlint",
name = "ktlint",
description = "An anti-bikeshedding Kotlin linter with built-in formatter",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be displayed on our website and when running sdk list, so should be written as a paragraph or sentence with punctuation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@eygraber eygraber requested a review from marc0der May 4, 2023 16:44
Copy link
Member

@marc0der marc0der left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marc0der marc0der merged commit 0ece7fe into sdkman:master May 7, 2023
@eygraber eygraber deleted the add-ktlint branch May 7, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants