Skip to content

Make Bash completion work with POSIX mode #978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 19, 2021
Merged

Conversation

helpermethod
Copy link
Member

Tests are now run with the --posix flag by default, to detect cases where something would break in POSIX mode.

Strangely enough, POSIX mode does not disable all of Bash's functionality, so things like here strings work. And on Bash 5.x, even process substitution works 😕.

Copy link
Member

@marc0der marc0der left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, although the formatting seems to be a bit funky, or is it just me?

@helpermethod
Copy link
Member Author

helpermethod commented Sep 19, 2021

Hi, it only looks that way because GitHub breaks the rather long curl invocation.

If you look at
https://github.com/sdkman/sdkman-cli/blob/c3469265208820e725f275f32d0ae6f750bd8542/contrib/completion/bash/sdk
everything is nicely indented.

@marc0der marc0der changed the title Make Bask completion work with POSIX mode Make Bash completion work with POSIX mode Sep 19, 2021
@helpermethod helpermethod merged commit 8c889a5 into master Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants