Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of the fold attribute when deep copying DateTime objects #776

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Fix handling of the fold attribute when deep copying DateTime objects #776

merged 1 commit into from
Dec 15, 2023

Conversation

sdispater
Copy link
Owner

Fixes #767

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.

@sdispater sdispater added the bug label Dec 15, 2023
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 15, 2023

CodSpeed Performance Report

Merging #776 will degrade performances by 19.45%

Comparing fix/deepcopy-fold (4fa9b8e) with master (1ff9a1c)

Summary

❌ 1 regressions
✅ 1 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark master fix/deepcopy-fold Change
❌ test_format 2.3 ms 2.8 ms -19.45%

@sdispater sdispater merged commit 0a884dd into master Dec 15, 2023
17 of 18 checks passed
@sdispater sdispater deleted the fix/deepcopy-fold branch December 15, 2023 00:10
@sdispater sdispater mentioned this pull request Dec 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deepcopy on DateTime produces incorrect offset in copy during dst transition
1 participant
@sdispater