-
-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mypy and fix issues #680
Merged
Secrus
merged 12 commits into
sdispater:master
from
bryanforbes:feature/mypy-improvement
Jun 10, 2023
Merged
Update mypy and fix issues #680
Secrus
merged 12 commits into
sdispater:master
from
bryanforbes:feature/mypy-improvement
Jun 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Secrus
reviewed
Dec 1, 2022
bryanforbes
force-pushed
the
feature/mypy-improvement
branch
from
March 3, 2023 17:06
deb08e2
to
63b7414
Compare
CodSpeed Performance ReportMerging #680 Summary
|
@bryanforbes could you update to the latest version of |
@Secrus this is ready to go |
Secrus
approved these changes
Jun 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
This upgrades
mypy
to 0.991 and fixes the errors associated with it. I've also removed themypy
check frompre-commit
and added a type checking step during unit testing. This requires runningpoetry install
twice to remove the type checking dependencies to ensure that there are no runtime dependencies on the type checking libraries (liketyping_extensions
). Another option would be to change thepre-commit
config to usemypy
viapoetry
, remove the third-partypre-commit
PR hook, and add a Github action that invokespre-commit
with the properpoetry install
. That can be done as a separate PR, though.