Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added JA translation #610

Merged
merged 6 commits into from
Aug 16, 2022
Merged

Added JA translation #610

merged 6 commits into from
Aug 16, 2022

Conversation

za
Copy link
Contributor

@za za commented Mar 22, 2022

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.

Added JA translation.

@Secrus
Copy link
Collaborator

Secrus commented Aug 7, 2022

@za please fix tests and pre-commit issues.

@za
Copy link
Contributor Author

za commented Aug 15, 2022

Hi @Secrus I've reformatted using black and now it's passed. Can you give me hint about the isort pre-commit check?

isort....................................................................Failed
- hook id: isort
- files were modified by this hook

Fixing /code/tests/localization/test_ja.py
Skipped 70 files

I am following the other test file and we're only importing one module which is pendulum.

@Secrus
Copy link
Collaborator

Secrus commented Aug 16, 2022

pre-commit.ci autofix

@Secrus Secrus merged commit ca589aa into sdispater:master Aug 16, 2022
@za
Copy link
Contributor Author

za commented Aug 16, 2022

Thanks for the review and merging the PR @Secrus !

@sdispater sdispater mentioned this pull request Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants