This repository has been archived by the owner on Feb 3, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 24
Follow symlinks when stripping vendor directories #199
Merged
Commits on Mar 20, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 3b518fc - Browse repository at this point
Copy the full SHA 3b518fcView commit details
Commits on Mar 21, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 5bf17a1 - Browse repository at this point
Copy the full SHA 5bf17a1View commit details -
Remove symlinks named 'vendor' when trimming
If a dependency contains a symlink named 'vendor', and that symlink points to a directory, delete the symlink. Keep the directory around - we can tackle that part when we get to actually pruning the vendored dependencies. Also, add some test helpers for testing filesystem state changes.
Configuration menu - View commit details
-
Copy full SHA for 352abcf - Browse repository at this point
Copy the full SHA 352abcfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 21bb8a5 - Browse repository at this point
Copy the full SHA 21bb8a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 00bcf14 - Browse repository at this point
Copy the full SHA 00bcf14View commit details -
Use absolute symlinks when testing on windows
Relative symlinks on windows confuse filepath.Walk. This is Go issue 17540, golang/go#17540. While waiting for that to get fixed, just use absolute symlinks in windows tests.
Configuration menu - View commit details
-
Copy full SHA for c281797 - Browse repository at this point
Copy the full SHA c281797View commit details -
Configuration menu - View commit details
-
Copy full SHA for b0151a8 - Browse repository at this point
Copy the full SHA b0151a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8720092 - Browse repository at this point
Copy the full SHA 8720092View commit details
Commits on Apr 1, 2017
-
Configuration menu - View commit details
-
Copy full SHA for c2a099c - Browse repository at this point
Copy the full SHA c2a099cView commit details
Commits on Apr 2, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 42ce45c - Browse repository at this point
Copy the full SHA 42ce45cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e1d193 - Browse repository at this point
Copy the full SHA 3e1d193View commit details -
Configuration menu - View commit details
-
Copy full SHA for d59bce6 - Browse repository at this point
Copy the full SHA d59bce6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 87ee43d - Browse repository at this point
Copy the full SHA 87ee43dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e19c27 - Browse repository at this point
Copy the full SHA 5e19c27View commit details
Commits on Apr 10, 2017
-
Configuration menu - View commit details
-
Copy full SHA for c32885d - Browse repository at this point
Copy the full SHA c32885dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6eda647 - Browse repository at this point
Copy the full SHA 6eda647View commit details -
Only remove symlinks to vendor dirs on non-Windows OSes
On Windows, we're unable to distinguish between symlinks and junctions. Deleting junctions is dangerous and appears to be able to delete the underlying folder, not just the junction that's pointing to a folder. That's unacceptably dangerous: a malicious repo could contain a junction named 'vendor' pointing at 'C:\\' and we'd delete all the user's data.
Configuration menu - View commit details
-
Copy full SHA for 06bcb96 - Browse repository at this point
Copy the full SHA 06bcb96View commit details -
Configuration menu - View commit details
-
Copy full SHA for edee8c8 - Browse repository at this point
Copy the full SHA edee8c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a38a0e - Browse repository at this point
Copy the full SHA 9a38a0eView commit details -
Configuration menu - View commit details
-
Copy full SHA for e640789 - Browse repository at this point
Copy the full SHA e640789View commit details -
Configuration menu - View commit details
-
Copy full SHA for 853e768 - Browse repository at this point
Copy the full SHA 853e768View commit details
Commits on Apr 11, 2017
-
It's too hard to create junctions with permissions that let filepath.Walk process them.
Configuration menu - View commit details
-
Copy full SHA for 05ef430 - Browse repository at this point
Copy the full SHA 05ef430View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.