Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support prettification of requests/responses #127

Merged
merged 4 commits into from
Aug 19, 2017

Conversation

rmannibucau
Copy link
Contributor

@rmannibucau rmannibucau commented Aug 17, 2017

Idea is to add a flag to prettify the payloads for string based backends (adoc and plain)

linked to issue: #125

Side note: made a few changes compared to 0.15 (I think they are ok but just want to mention them):

  1. enum get merged into a string instead of something not json ("foo"|"bar" would be "foo|bar")
  2. replaced visit(collection) by visitStart/visitEnd(collection) to be able to ensure the [ and ] are symmetric (was not the case)
  3. changed a bit the adoc output (added some \n) to ensure it renders properly in html even with prettification (so you can get few more empty lines which are not affecting the rendering normally)

@sdaschner sdaschner merged commit cf5ede6 into sdaschner:master Aug 19, 2017
sdaschner added a commit that referenced this pull request Aug 19, 2017
@sdaschner
Copy link
Owner

Cool, thanks a lot for contributing!

I have changed the configuration a bit, actually the Backend is configurable using a map. Also renamed the CLI option. Please have a look.

I have uploaded the 0.16-SNAPSHOT version in the Maven snapshot repository, could you please check whether that is all fine? :-)

@rmannibucau
Copy link
Contributor Author

Looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants