Skip to content

[WIP] Fix remaining loop devices manipulations in NodeSetup E2Es #2987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[WIP] Fix remaining loop devices manipulations in NodeSetup E2Es #2987

wants to merge 1 commit into from
+14 −24

Conversation

czeslavo
Copy link
Contributor

@czeslavo czeslavo commented Oct 2, 2025

Description of your changes: It appears that when fixing the problem described in #2743, I missed a couple of commands that still cause flakiness. This PR should solve it.

Which issue is resolved by this Pull Request:
Should fix #2550.

@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@scylla-operator-bot scylla-operator-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 2, 2025
@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: czeslavo
Once this PR has been reviewed and has the lgtm label, please assign mflendrich for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czeslavo czeslavo added the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label Oct 2, 2025
@scylla-operator-bot scylla-operator-bot bot removed the do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Oct 2, 2025
@czeslavo czeslavo added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 2, 2025
@scylla-operator-bot scylla-operator-bot bot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Oct 2, 2025
@czeslavo
Copy link
Contributor Author

czeslavo commented Oct 2, 2025

/test images
/test e2e-openshift-aws-serial

@czeslavo
Copy link
Contributor Author

czeslavo commented Oct 2, 2025

/test e2e-gke-serial

@czeslavo czeslavo removed the do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Oct 2, 2025
@czeslavo
Copy link
Contributor Author

czeslavo commented Oct 3, 2025

/test e2e-openshift-aws-serial

1 similar comment
@czeslavo
Copy link
Contributor Author

czeslavo commented Oct 3, 2025

/test e2e-openshift-aws-serial

@czeslavo czeslavo force-pushed the use-in-container-device-path branch from 0336d9b to ba0fe4e Compare October 6, 2025 11:56
@scylla-operator-bot scylla-operator-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 6, 2025
@czeslavo
Copy link
Contributor Author

czeslavo commented Oct 6, 2025

/test images
/test e2e-openshift-aws-serial

@czeslavo czeslavo force-pushed the use-in-container-device-path branch from ba0fe4e to a148940 Compare October 6, 2025 14:14
@czeslavo
Copy link
Contributor Author

czeslavo commented Oct 6, 2025

/test images
/test e2e-openshift-aws-serial
/test e2e-gke-serial

@czeslavo czeslavo force-pushed the use-in-container-device-path branch 2 times, most recently from 3fa24ec to 3050455 Compare October 6, 2025 17:03
@czeslavo
Copy link
Contributor Author

czeslavo commented Oct 6, 2025

/test images
/test e2e-openshift-aws-serial

@czeslavo
Copy link
Contributor Author

czeslavo commented Oct 6, 2025

/test e2e-gke-serial

@czeslavo
Copy link
Contributor Author

czeslavo commented Oct 7, 2025

/test e2e-openshift-aws-serial

@czeslavo czeslavo force-pushed the use-in-container-device-path branch from 3050455 to baa95a5 Compare October 7, 2025 10:27
@czeslavo
Copy link
Contributor Author

czeslavo commented Oct 7, 2025

/test images
/test e2e-openshift-aws-serial

@czeslavo czeslavo force-pushed the use-in-container-device-path branch from baa95a5 to cb292ec Compare October 7, 2025 11:06
@scylla-operator-bot scylla-operator-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 7, 2025
@czeslavo
Copy link
Contributor Author

czeslavo commented Oct 7, 2025

/test images
/test e2e-openshift-aws-serial

@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

@czeslavo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gke-serial 3050455 link true /test e2e-gke-serial
ci/prow/e2e-openshift-aws-serial cb292ec link false /test e2e-openshift-aws-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@czeslavo
Copy link
Contributor Author

czeslavo commented Oct 7, 2025

/test images
/test e2e-openshift-aws-serial

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flake - Node Setup should successfully start a failed mount unit with a corrupted filesystem when it's overwritten with a clean one [Serial]
1 participant
@czeslavo