Extend node tuning with kernel parameter configuration (sysctls)

[rzetelskik]

Description of your changes: Following the enhancement proposal, this PR extends the NodeConfig API with support for node-level kernel parameter configuration (sysctls). This bridges the feature gap between v1.ScyllaCluster and v1alpha1.ScyllaDBCluster APIs. ScyllaCluster.scylla.scylladb.com/v1.spec.sysctls is simultaneously deprecated.

Which issue is resolved by this Pull Request:
Resolves #2457

/kind feature
/priority important-soon

[scylla-operator-bot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[rzetelskik]

/test all

[rzetelskik]

/test all

[Copilot]

Pull Request Overview

This PR extends the NodeConfig functionality to support kernel parameter (sysctl) configuration, providing a modern replacement for the deprecated ScyllaCluster.spec.sysctls field. The implementation adds new APIs, validation, job execution logic, and deprecation warnings.

• Adds sysctls field to NodeConfig spec for kernel parameter configuration
• Implements validation for sysctl names and prevents duplicates
• Creates dedicated jobs and RBAC resources for applying sysctls on nodes
• Deprecates ScyllaCluster.spec.sysctls with proper warnings and migration path

Reviewed Changes

Copilot reviewed 45 out of 45 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
pkg/api/scylla/v1alpha1/types_nodeconfig.go	Adds sysctls field to NodeConfig spec
pkg/api/scylla/validation/nodeconfig_validation.go	Implements sysctl validation logic
pkg/controller/nodetune/resource.go	Creates sysctls job generation and execution logic
pkg/controller/nodeconfig/resource.go	Adds RBAC resources for sysctls service account
pkg/naming/constants.go	Defines new job types and service account names
test/e2e/set/scyllacluster/scyllacluster_webhooks.go	Tests deprecation warnings for ScyllaCluster sysctls
test/e2e/set/nodeconfig/nodeconfig_optimizations.go	E2E tests for NodeConfig sysctls functionality

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[rzetelskik]

/test all

[rzetelskik]

Had to update managed-hash annotations in unit tests after #2940 merged.

[rzetelskik]

@rzetelskik: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gke-release-script-latest 5b5b797 link true /test e2e-gke-release-script-latest
ci/prow/e2e-gke-parallel-clusterip 08fb859 link unknown /test e2e-gke-parallel-clusterip
ci/prow/e2e-gke-multi-datacenter-parallel 90b65e0 link true /test e2e-gke-multi-datacenter-parallel
Full PR test history. Your PR dashboard.

cluster provisioning failed
/test images
/retest

[mflendrich]

/lgtm
assuming prior lgtm and only a rebase happening between the previous lgtm and now 👍

[scylla-operator-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czeslavo, mflendrich, rzetelskik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mflendrich,rzetelskik]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rzetelskik]

/test images
/retest

[rzetelskik]

/retest

[rzetelskik]

/test images
/retest

[rzetelskik]

@rzetelskik: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gke-release-script-latest 5b5b797 link true /test e2e-gke-release-script-latest
ci/prow/e2e-gke-multi-datacenter-parallel 90b65e0 link true /test e2e-gke-multi-datacenter-parallel
Full PR test history. Your PR dashboard.

/test images
/retest

[rzetelskik]

@rzetelskik: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gke-release-script-latest 5b5b797 link true /test e2e-gke-release-script-latest
ci/prow/e2e-gke-multi-datacenter-parallel 90b65e0 link true /test e2e-gke-multi-datacenter-parallel
Full PR test history. Your PR dashboard.

/test images
/retest

[rzetelskik]

@rzetelskik: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gke-release-script-latest	5b5b797	link	true	/test e2e-gke-release-script-latest
ci/prow/e2e-gke-multi-datacenter-parallel	90b65e0	link	unknown	/test e2e-gke-multi-datacenter-parallel

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

/retest

[rzetelskik]

/test images
/retest

[scylla-operator-bot]

@rzetelskik: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gke-release-script-latest	5b5b797	link	true	/test e2e-gke-release-script-latest
ci/prow/e2e-gke-multi-datacenter-parallel	90b65e0	link	true	/test e2e-gke-multi-datacenter-parallel

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.