Skip to content

Conversation

wyfo
Copy link
Contributor

@wyfo wyfo commented Jan 23, 2023

Copy link
Contributor

@avelanarius avelanarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I'll do a few small stylistic changes myself (around formatting, null != sslConfig.trustStorePath -> sslConfig.trustStorePath != null, etc.) before merging.

@wyfo
Copy link
Contributor Author

wyfo commented Jan 27, 2023

around formatting, null != sslConfig.trustStorePath -> sslConfig.trustStorePath != null

Actually, this code is copy-pasted from https://github.com/scylladb/kafka-connect-scylladb/blob/master/src/main/java/io/connect/scylladb/ScyllaDbSessionFactory.java#L81, so you may want to apply your modification there too 😄

By the way, I had to adapt the code from the sink connector, because it is using org.apache.kafka.connect.errors.ConnectException, which is not available here. So I've replaced it with a simple RuntimeException. Was there a better exception to use here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants