Fix row-thread mapping for sequential workloads
#153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vponomaryov
force-pushed
the
fix-sequential-workload
branch
from
fa13afb to
6d0c559
Compare
CodeLieutenant
approved these changes
Nov 5, 2024
dkropachev
approved these changes
Nov 5, 2024
Before this change scylla-bench was distributing rows among threads correctly only when number of partitions was divisible by number of threads without remainder. A bit worse case was appearing when there was division remainder. And the worst case was when number of threads was bigger than number of partitions. In this case last thread was handling all of the rows and all of other threads were idle. So, fix it by spreading rows evenly among all of the threads as much as possible. Closes: scylladb#138
vponomaryov
force-pushed
the
fix-sequential-workload
branch
from
6d0c559 to
e875ca7
Compare
dkropachev
approved these changes
Nov 5, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change scylla-bench was distributing rows among threads correctly only when number of partitions was divisible by number of threads without remainder.
A bit worse case was appearing when there was division remainder.
And the worst case was when number of threads was bigger than number of partitions. In this case last thread was handling all of the rows and all of other threads were idle.
So, fix it by spreading rows evenly among all of the threads as much as possible.
Closes: #138